8000 compute log euclidean in closed form by SaitejaUtpala · Pull Request #1516 · geomstats/geomstats · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

compute log euclidean in closed form #1516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2022
Merged

compute log euclidean in closed form #1516

merged 2 commits into from
Apr 30, 2022

Conversation

SaitejaUtpala
Copy link
Collaborator
@SaitejaUtpala SaitejaUtpala commented Apr 30, 2022 •
edited
Loading

Checklist

  • My pull request has a clear and explanatory title.
  • If neccessary, my code is vectorized.
  • I have added apropriate unit tests.
  • I have made sure the code passes all unit tests. (refer to comment below)
  • My PR follows PEP8 guidelines. (refer to comment below)
  • My PR follows geomstats coding style and API.
  • My code is properly documented and I made sure the documentation renders properly. (Link)
  • I have linked to issues and PRs that are relevant to this PR.

Description

Issue

Additional context

@codecov
Copy link
codecov bot commented Apr 30, 2022 •
edited
Loading

Codecov Report

Merging #1516 (5a43e8a) into master (f40f3e6) will increase coverage by 0.48%.
The diff coverage is 100.00%.

❗ Current head 5a43e8a differs from pull request most recent head 8efcfe4. Consider uploading reports for the commit 8efcfe4 to get more accurate results

@@            Coverage Diff             @@
##           master    #1516      +/-   ##
==========================================
+ Coverage   91.61%   92.08%   +0.48%     
==========================================
  Files          92      106      +14     
  Lines        9197    10109     +912     
==========================================
+ Hits         8425     9308     +883     
- Misses        772      801      +29
Flag Coverage Δ
autograd 90.97% <100.00%> (-0.48%) ⬇️
numpy 89.33% <100.00%> (+0.30%) ⬆️
pytorch 82.87% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
geomstats/geometry/matrices.py 97.26% <ø> (+0.02%) ⬆️
geomstats/geometry/spd_matrices.py 95.71% <100.00%> (+0.07%) ⬆️
...omstats/geometry/full_rank_correlation_matrices.py 95.59% <0.00%> (-4.41%) ⬇️
geomstats/geometry/manifold.py 91.12% <0.00%> (-2.22%) ⬇️
geomstats/learning/kmeans.py 86.03% <0.00%> (-1.78%) ⬇️
geomstats/geometry/fiber_bundle.py 91.90% <0.00%> (-0.10%) ⬇️
geomstats/geometry/base.py 94.95% <0.00%> (-0.05%) ⬇️
geomstats/geometry/landmarks.py 88.89% <0.00%> (ø)
geomstats/geometry/hyperboloid.py 85.60% <0.00%> (ø)
geomstats/geometry/general_linear.py 100.00% <0.00%> (ø)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa00f02...8efcfe4. Read the comment docs.

@SaitejaUtpala
Copy link
Collaborator Author

@ninamiolane Deep source is not with current PR changes.

@SaitejaUtpala SaitejaUtpala merged commit e6a0fdd into geomstats:master Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SaitejaUtpala
0