8000 Enhance notebook on cell shapes by analyzing with general elastic metric by ninamiolane · Pull Request #1526 · geomstats/geomstats · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Enhance notebook on cell shapes by analyzing with general elastic metric #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2022
Merged

Enhance notebook on cell shapes by analyzing with general elastic metric #1526

merged 1 commit into from
May 4, 2022

Conversation

ninamiolane
Copy link
Collaborator
@ninamiolane ninamiolane commented May 4, 2022 •
edited
Loading

Checklist

  • My pull request has a clear and explanatory title.
  • If neccessary, my code is vectorized.
  • I have added apropriate unit tests.
  • I have made sure the code passes all unit tests: the failing tests are not mine.
  • My PR follows PEP8 guidelines.
  • My PR follows geomstats coding style and API.
  • My code is properly documented and I made sure the documentation renders properly. (Link)
  • I have linked to issues and PRs that are relevant to this PR.

Description

This PR modifies the notebook on cell shape analysis by providing new histograms of distances and quantile plots that rely on the general elastic metric (with parameters a and b), in addition to the same plots using the standard srv metric (corresponding to a=1, and b=0.5).

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@ninamiolane ninamiolane marked this pull request as draft May 4, 2022 23:37
@codecov
Copy link
codecov bot commented May 4, 2022

Codecov Report

Merging #1526 (31f0b48) into master (3e599c9) will decrease coverage by 2.52%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1526      +/-   ##
==========================================
- Coverage   91.79%   89.28%   -2.51%     
==========================================
  Files         102       97       -5     
  Lines        9485     9223     -262     
==========================================
- Hits         8706     8234     -472     
- Misses        779      989     +210
Flag Coverage Δ
autograd ?
numpy 89.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
geomstats/geometry/pullback_metric.py 25.81% <0.00%> (-74.19%) ⬇️
geomstats/learning/geodesic_regression.py 31.17% <0.00%> (-56.49%) ⬇️
geomstats/geometry/sub_riemannian_metric.py 43.40% <0.00%> (-50.94%) ⬇️
geomstats/geometry/fiber_bundle.py 62.17% <0.00%> (-29.72%) ⬇️
geomstats/geometry/connection.py 83.22% <0.00%> (-11.67%) ⬇️
geomstats/geometry/riemannian_metric.py 89.10% <0.00%> (-8.18%) ⬇️
geomstats/geometry/hypersphere.py 80.91% <0.00%> (-7.11%) ⬇️
geomstats/tests.py 66.11% <0.00%> (-1.69%) ⬇️
geomstats/_backend/__init__.py 76.20% <0.00%> (-1.58%) ⬇️
geomstats/learning/expectation_maximization.py 87.78% <0.00%> (-1.11%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e599c9...31f0b48. Read the comment docs.

@ninamiolane ninamiolane marked this pull request as ready for review May 4, 2022 23:52
@ninamiolane ninamiolane merged commit 414b683 into geomstats:master May 4, 2022
@ninamiolane ninamiolane deleted the elastic-ab branch May 4, 2022 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ninamiolane
0