8000 Remove fixme and todo workflows by luisfpereira · Pull Request #1548 · geomstats/geomstats · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove fixme and todo workflows #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2022
Merged

Remove fixme and todo workflows #1548

merged 1 commit into from
May 30, 2022

Conversation

luisfpereira
Copy link
Collaborator

This removes fixme and todo workflows (which were creating issues when finding tags #TODO and #FIXME in the code).

Nevertheless, these tags should be used only at the bare minimum (todos and fixes should be done before merging).

@luisfpereira luisfpereira requested a review from ninamiolane May 25, 2022 16:46
@codecov
Copy link
codecov bot commented May 25, 2022 •
edited
Loading

Codecov Report

Merging #1548 (0b1bd98) into master (9c17cce) will increase coverage by 2.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1548      +/-   ##
==========================================
+ Coverage   89.45%   91.68%   +2.24%     
==========================================
  Files         102      111       +9     
  Lines       10305    11205     +900     
==========================================
+ Hits         9217    10272    +1055     
+ Misses       1088      933     -155
Flag Coverage Δ
autograd 90.38% <ø> (?)
numpy 87.15% <ø> (-0.01%) ⬇️
pytorch 81.04% <ø> (?)
tensorflow 76.12% <ø> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
geomstats/learning/kmedoids.py 92.60% <0.00%> (-3.70%) ⬇️
geomstats/_backend/pytorch/autodiff.py 98.12% <0.00%> (ø)
geomstats/_backend/pytorch/linalg.py 84.82% <0.00%> (ø)
geomstats/_backend/autograd/common.py 88.89% <0.00%> (ø)
geomstats/_backend/pytorch/__init__.py 95.21% <0.00%> (ø)
geomstats/_backend/pytorch/random.py 80.77% <0.00%> (ø)
geomstats/_backend/autograd/linalg.py 95.90% <0.00%> (ø)
geomstats/_backend/autograd/random.py 100.00% <0.00%> (ø)
geomstats/_backend/autograd/__init__.py 98.50% <0.00%> (ø)
geomstats/_backend/autograd/autodiff.py 97.73% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c17cce...0b1bd98. Read the comment docs.

@luisfpereira luisfpereira merged commit f284cc3 into geomstats:master May 30, 2022
@luisfpereira luisfpereira deleted the workflows branch May 30, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninamiolane ninamiolane Awaiting requested review from ninamiolane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@luisfpereira
0