8000 Fix empty list array creation for torch by luisfpereira · Pull Request #1558 · geomstats/geomstats · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix empty list array creation for torch #1558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2022
Merged

Fix empty list array creation for torch #1558

merged 1 commit into from
Jun 2, 2022

Conversation

luisfpereira
Copy link
Collaborator
@luisfpereira luisfpereira commented Jun 2, 2022 •
edited
Loading

Fix gs.array([]) for torch.

Closes #1347.

@codecov
Copy link
codecov bot commented Jun 2, 2022

Codecov Report

Merging #1558 (04e055b) into master (87ba3d4) will decrease coverage by 4.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1558      +/-   ##
==========================================
- Coverage   91.24%   87.22%   -4.02%     
==========================================
  Files         105      100       -5     
  Lines       10062     9800     -262     
==========================================
- Hits         9180     8547     -633     
- Misses        882     1253     +371
Flag Coverage Δ
autograd ?
numpy 87.22% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
geomstats/learning/geodesic_regression.py 31.17% <0.00%> (-56.49%) ⬇️
geomstats/geometry/pullback_metric.py 33.07% <0.00%> (-54.83%) ⬇️
geomstats/geometry/sub_riemannian_metric.py 43.40% <0.00%> (-50.94%) ⬇️
geomstats/information_geometry/gamma.py 50.68% <0.00%> (-40.26%) ⬇️
geomstats/geometry/fiber_bundle.py 62.17% <0.00%> (-29.72%) ⬇️
geomstats/geometry/connection.py 83.34% <0.00%> (-11.59%) ⬇️
geomstats/geometry/hypersphere.py 80.91% <0.00%> (-7.11%) ⬇️
geomstats/geometry/riemannian_metric.py 89.85% <0.00%> (-7.03%) ⬇️
geomstats/_backend/__init__.py 76.20% <0.00%> (-1.58%) ⬇️
geomstats/geometry/grassmannian.py 93.69% <0.00%> (-1.05%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fb4835...04e055b. Read the comment docs.

@luisfpereira luisfpereira merged commit f0ef895 into geomstats:master Jun 2, 2022
@luisfpereira luisfpereira deleted the torch branch June 2, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gs.array of empty list does not work for pytorch backend
1 participant
@luisfpereira
0