8000 Real world application: optimization of traffic in Sao Paulo by Jules-Deschamps · Pull Request #1569 · geomstats/geomstats · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Real world application: optimization of traffic in Sao Paulo #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jun 15, 2022
Merged

Real world application: optimization of traffic in Sao Paulo #1569

merged 17 commits into from
Jun 15, 2022

Conversation

Jules-Deschamps
Copy link
Collaborator
@Jules-Deschamps Jules-Deschamps commented Jun 8, 2022 •
edited
Loading

This notebook presents a simple use case of information geometry, in the context of traffic optimization in Sao Paulo.
We rely on a dataset listing all traffic jams in Sao Paulo for the past two decades to propose a solution as for what roads to renovate.

@codecov
Copy link
codecov bot commented Jun 8, 2022 •
edited
Loading

Codecov Report

Merging #1569 (5753e5f) into master (6f260f7) will increase coverage by 0.01%.
The diff coverage is 67.57%.

@@            Coverage Diff             @@
##           master    #1569      +/-   ##
==========================================
+ Coverage   89.23%   89.24%   +0.01%     
==========================================
  Files         107      107              
  Lines       10659    10715      +56     
==========================================
+ Hits         9511     9561      +50     
- Misses       1148     1154       +6
Flag Coverage Δ
autograd 88.83% <67.57%> (+0.01%) ⬆️
pytorch 79.79% <67.57%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
geomstats/datasets/utils.py 91.67% <35.30%> (-8.33%) ⬇️
geomstats/datasets/_base.py 42.11% <66.67%> (+42.11%) ⬆️
geomstats/information_geometry/gamma.py 91.43% <100.00%> (+0.49%) ⬆️
geomstats/geometry/product_riemannian_metric.py 91.41% <0.00%> (-2.00%) ⬇️
geomstats/learning/frechet_mean.py 96.63% <0.00%> (-0.26%) ⬇️
geomstats/geometry/discrete_curves.py 78.99% <0.00%> (+0.28%) ⬆️
geomstats/geometry/euclidean.py 94.12% <0.00%> (+0.37%) ⬆️
geomstats/geometry/product_manifold.py 97.13% <0.00%> (+2.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f260f7...5753e5f. Read the comment docs.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@Jules-Deschamps Jules-Deschamps changed the title addition of maximum likelihood fit Real world application: optimization of traffic in Sao Paulo Jun 9, 2022
@alebrigant alebrigant reopened this Jun 9, 2022
@alebrigant
Copy link
Collaborator

Great, the explanations are very clear ! Some first comments:

  • Section 3.1.2.: replace $\P(T_r = t)$ by the density $f(t)$
  • Section 3.2.1.: I would rephrase "it is obvious that it is much more efficient to renovate an abandonned road than a fluid one" into "one can argue that it is more efficient to renovate a road where traffic jams are frequent than a road on which the traffic is almost fluid".
  • Section 3.2.2.: remove "unit" in "unit tangent vector" as it is not of unit length.
  • Paragraph after "Comparison of different renovation efforts" figure: The fact that these results validate our observations and expected consequences of renovations...": this should be explained. Why is it expected that the kappa grows more in some cases ? (what we discussed yesterday). Also, maybe insist on the fact that, for fixed coordinates of the tangent vector, the norm will change depending on the base point in the case of the Gamma Riemannian geometry contrary to Euclidean geometry.

@Jules-Deschamps
Copy link
Collaborator Author

Ok thanks! As for the unit vector, I thought it could be a notation to simplify future equations instead of normalizing the tangent vector every time (if that's what you are referring to).

@alebrigant alebrigant requested a review from ninamiolane June 13, 2022 14:10
ninamiolane
ninamiolane approved these changes Jun 13, 2022
View reviewed changes
Copy link
Collaborator
@ninamiolane ninamiolane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks! Just rename the notebook 18_real_world... instead of n_real_world... :D then, good to merge!

@luisfpereira
Copy link
Collaborator

@Jules-Deschamps, I've added the download of the dataset from a remote source. Let me know if I've broken anything!

Later, please discuss with @alebrigant about the creation of a proper figshare record to ensure we give the credit of the dataset to the right people.

ninamiolane
ninamiolane requested changes Jun 14, 2022
View reviewed changes
Copy link
Collaborator
@ninamiolane ninamiolane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DeepSource errors and the unit-tests errors need to be addressed.

@ninamiolane ninamiolane merged commit 01195b5 into geomstats:master Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninamiolane ninamiolane ninamiolane requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jules-Deschamps @alebrigant @luisfpereira @ninamiolane
0