Fix shape of HypersphereMetric and KendallShapeMetric #1560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1560 +/- ##
=======================================
Coverage 87.22% 87.22%
=======================================
Files 100 100
Lines 9800 9800
=======================================
Hits 8547 8547
Misses 1253 1253
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Looks good. Thanks! |
luisfpereira
added a commit
that referenced
this pull request
Jun 2, 2022
Fix lint issues due to #1560
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
The constructors of HypersphereMetric and KendallShapeMetric do not (not correctly) handle the shape parameter. In fact, it gets lost on the way down to RiemannianMetric.
It can be solved with some slight modifications in the constructors of HypersphereMetric, KendallShapeMetric and QuotientMetric.
Issue
This closes #1559 (Shape not set correctly for HypersphereMetric and KendallShapeMetric).