8000 Fix typo in notebooks tests by luisfpereira · Pull Request #1577 · geomstats/geomstats · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix typo in notebooks tests #1577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2022
Merged

Fix typo in notebooks tests #1577

merged 1 commit into from
Jun 14, 2022

Conversation

luisfpereira
Copy link
Collaborator

Fixes typo in notebooks tests and slightly reorganizes code in the file.

@codecov
Copy link
codecov bot commented Jun 14, 2022 •
edited
Loading

Codecov Report

Merging #1577 (ae6953c) into master (6f260f7) will increase coverage by 1.91%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1577      +/-   ##
==========================================
+ Coverage   89.23%   91.14%   +1.91%     
==========================================
  Files         107      108       +1     
  Lines       10659    10308     -351     
==========================================
- Hits         9511     9394     -117     
+ Misses       1148      914     -234
Flag Coverage Δ
autograd 88.83% <ø> (ø)
numpy 87.21% <ø> (?)
pytorch ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
geomstats/tests.py 67.80% <0.00%> (-16.94%) ⬇️
geomstats/visualization/special_euclidean.py 92.31% <0.00%> (-2.56%) ⬇️
geomstats/learning/geodesic_regression.py 87.67% <0.00%> (-1.94%) ⬇️
geomstats/_backend/pytorch/linalg.py
geomstats/_backend/pytorch/__init__.py
geomstats/_backend/pytorch/autodiff.py
geomstats/_backend/pytorch/random.py
geomstats/_backend/numpy/random.py 100.00% <0.00%> (ø)
geomstats/_backend/numpy/linalg.py 94.12% <0.00%> (ø)
geomstats/_backend/numpy/autodiff.py 90.00% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f260f7...ae6953c. Read the comment docs.

ninamiolane
ninamiolane approved these changes Jun 14, 2022
View reviewed changes
Copy link
Collaborator
@ninamiolane ninamiolane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ninamiolane ninamiolane merged commit 16eb5b0 into geomstats:master Jun 14, 2022
@luisfpereira luisfpereira deleted the test_notebooks branch June 16, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninamiolane ninamiolane ninamiolane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luisfpereira @ninamiolane
0