Clean backend (only a bit) #1570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1570 +/- ##
==========================================
+ Coverage 88.95% 91.31% +2.36%
==========================================
Files 101 107 +6
Lines 10089 10291 +202
==========================================
+ Hits 8974 9396 +422
+ Misses 1115 895 -220
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ninamiolane
approved these changes
Jun 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans slightly the backend.
A better distinction between private and public methods is done (it makes it easier to understand what will be imported to
gs).Additionally, the
geomstats._backend_common.pyis created to avoid definition the same function for all backends. The handling of imports is changed to ensureBackendImporterlooks into this new file.This is the starting point of more meaningful changes in the backends related to precision.