8000 Start fixing inheritance in Product/NFold/Landmarks/Curves Spaces by ninamiolane · Pull Request #1581 · geomstats/geomstats · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Start fixing inheritance in Product/NFold/Landmarks/Curves Spaces #1581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 14, 2022
Merged

Start fixing inheritance in Product/NFold/Landmarks/Curves Spaces #1581

merged 2 commits into from
Jun 14, 2022

Conversation

ninamiolane
Copy link
Collaborator
@ninamiolane ninamiolane commented Jun 14, 2022 •
edited
Loading

The organization of files and associated inheritance of Python classes in the Product (Manifold/Metric), NFold (Manifold/Metric), Landmarks, Curves and their metric is a mess.

This PR starts addressing this problem by addressing a few tasks of Issue #1492

Checklist

  • My pull request has a clear and explanatory title.
  • If neccessary, my code is vectorized.
  • I have added apropriate unit tests.
  • I have made sure the code passes all unit tests. (refer to comment below)
  • My PR follows PEP8 guidelines. (refer to comment below)
  • My PR follows geomstats coding style and API.
  • My code is properly documented and I made sure the documentation renders properly. (Link)
  • I have linked to issues and PRs that are relevant to this PR.

Description

Issue

Additional context

@codecov
Copy link
codecov bot commented Jun 14, 2022

Codecov Report

Merging #1581 (1b6aa2f) into master (16eb5b0) will increase coverage by 0.03%.
The diff coverage is 89.37%.

@@            Coverage Diff             @@
##           master    #1581      +/-   ##
==========================================
+ Coverage   89.90%   89.93%   +0.03%     
==========================================
  Files         107      107              
  Lines       10602    10610       +8     
==========================================
+ Hits         9531     9541      +10     
+ Misses       1071     1069       -2
Flag Coverage Δ
numpy 87.22% <89.37%> (+0.04%) ⬆️
pytorch 79.73% <89.37%> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
geomstats/geometry/product_riemannian_metric.py 91.41% <86.49%> (-2.00%) ⬇️
geomstats/geometry/discrete_curves.py 78.99% <100.00%> (+0.28%) ⬆️
geomstats/geometry/euclidean.py 94.12% <100.00%> (+0.37%) ⬆️
geomstats/geometry/product_manifold.py 97.13% <100.00%> (+2.21%) ⬆️
geomstats/geometry/stratified/wald_space.py 90.22% <0.00%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d66728...1b6aa2f. Read the comment docs.

@ninamiolane
Copy link
Collaborator Author

Failing tests are not related to this PR. Merging as we need this fix, and the PR does not add much.

@ninamiolane ninamiolane merged commit 46f9ab7 into geomstats:master Jun 14, 2022
< 6706 /div>
@ninamiolane ninamiolane deleted the fix-geod-sign branch June 14, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ninamiolane
0