Add ability of using kwargs in test functions #1609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LPereira95 Nice addition! I just have one comment. Once all thing are completed in testing end. I would suggest to write up how different pieces are interacting and how test data is built in flow chart so that if someone wants to look under hood or suggest improvement it becomes easy. We can probably put that on docs. Also congrats on merging giant PR #1517 |
SaitejaUtpala
approved these changes
Jul 26, 2022
|
Thanks @SaitejaUtpala! I think it is a great suggestion and I'll definitely do it as soon as I finish the changes (there's still some ideas to be developed). Thank you also again for all the work you've put in developing this framework (very unique and powerful). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow to do something like:
This is achieved by changing the function signature to e.g.
(self, a, b, c)and passing the default as data value if not encountered in the datum.This feature is handy sometimes to reduce verbose in data creation.