8000 Template for the issue tracker by nanjekyejoannah · Pull Request #1603 · geomstats/geomstats · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Template for the issue tracker #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 18, 2022
Merged

Template for the issue tracker #1603

merged 3 commits into from
Jul 18, 2022

Conversation

nanjekyejoannah
Copy link
Contributor
@nanjekyejoannah nanjekyejoannah commented Jul 11, 2022 •
edited
Loading

This is a proposed template covering details for a bug report, as discussed in our last call with @LPereira95 but also noted in #1597

@nanjekyejoannah
Copy link
Contributor Author

cc @LPereira95 @ninamiolane

luisfpereira
luisfpereira reviewed Jul 12, 2022
View reviewed changes
Copy link
Collaborator
@luisfpereira luisfpereira left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanjekyejoannah can you make it slightly closer to sklearn's (here and configuration)?

I like specially the fact that they have a code block where to write the code to reproduce, and the fields "Expected results" and "Actual results" (I may prefer the word "behavior" that you use). The "Describe the bug" is also very meaningful.

@nanjekyejoannah
Copy link
Contributor Author

I have done some modifications, PTAL

@codecov
Copy link
codecov bot commented Jul 13, 2022 •
edited
Loading

Codecov Report

Merging #1603 (6488617) into master (56cce9e) will increase coverage by 2.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1603      +/-   ##
==========================================
+ Coverage   88.52%   90.90%   +2.38%     
==========================================
  Files         104      110       +6     
  Lines       10263    10594     +331     
==========================================
+ Hits         9084     9629     +545     
+ Misses       1179      965     -214
Flag Coverage Δ
autograd 88.62% <ø> (+0.11%) ⬆️
numpy 87.11% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
geomstats/_backend/numpy/autodiff.py 90.00% <0.00%> (ø)
geomstats/geometry/sasaki_metric.py 98.94% <0.00%> (ø)
geomstats/_backend/numpy/__init__.py 98.78% <0.00%> (ø)
geomstats/_backend/numpy/_common.py 88.89% <0.00%> (ø)
geomstats/_backend/numpy/random.py 100.00% <0.00%> (ø)
geomstats/_backend/numpy/linalg.py 94.12% <0.00%> (ø)
geomstats/learning/expectation_maximization.py 80.45% <0.00%> (+0.56%) ⬆️
geomstats/geometry/symmetric_matrices.py 92.14% <0.00%> (+1.13%) ⬆️
geomstats/geometry/stratified/graph_space.py 53.62% <0.00%> (+1.21%) ⬆️
geomstats/geometry/stratified/point_set.py 96.08% <0.00%> (+25.50%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56cce9e...6488617. Read the comment docs.

luisfpereira
luisfpereira approved these changes Jul 13, 2022
View reviewed changes
Copy link
Collaborator
@luisfpereira luisfpereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nanjekyejoannah, it looks great!

I think we should update issues link and merge.

.github/ISSUE_TEMPLATE/bug-report.yml Outdated
If you're new to Geomstats, consider the following options first:

- reading the Geomstats documentation: https://geomstats.github.io/
- searching our existing issue tracker for a similar issue (https://github.com/geomstats/geomstats) to see if
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/geomstats/geomstats/issues instead?

@nanjekyejoannah
Copy link
Contributor Author
nanjekyejoannah commented Jul 14, 2022 •
edited
Loading

I have updated, thank you, I can now use it in the docs, i guess.

@luisfpereira luisfpereira merged commit d1aa07d into geomstats:master Jul 18, 2022
@luisfpereira
Copy link
Collaborator

Thanks @nanjekyejoannah!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisfpereira luisfpereira luisfpereira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nanjekyejoannah @luisfpereira
0