8000 ADD geodesic for elastic curves + FIX tests inheritance in RiemannianMetric, Connection, & ElasticMetric by ninamiolane · Pull Request #1622 · geomstats/geomstats · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ADD geodesic for elastic curves + FIX tests inheritance in RiemannianMetric, Connection, & ElasticMetric #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 11, 2022
Merged

ADD geodesic for elastic curves + FIX tests inheritance in RiemannianMetric, Connection, & ElasticMetric #1622

merged 9 commits into from
Aug 11, 2022

Conversation

ninamiolane
Copy link
Collaborator
@ninamiolane ninamiolane commented Aug 11, 2022 •
edited
Loading

This PR:

BUG: Weirdly, the geodesic unit-tests are skipped for TestElasticMetric whereas no skip_ flag is put, see screenshot:

Screen Shot 2022-08-11 at 8 55 26 AM

It should be skipped for SRVMetric, which has skip_test_geodesic_bvp_belongs

Checklist

  • My pull request has a clear and explanatory title.
  • If neccessary, my code is vectorized.
  • I have added apropriate unit tests.
  • I have made sure the code passes all unit tests. (refer to comment below)
  • My PR follows PEP8 guidelines. (refer to comment below)
  • My PR follows geomstats coding style and API.
  • My code is properly documented and I made sure the documentation renders properly. (Link)
  • I have linked to issues and PRs that are relevant to this PR.

Description

Issue

Additional context

@ninamiolane ninamiolane mentioned this pull request Aug 11, 2022
Closed
@ninamiolane
Copy link
Collaborator Author

The failing tests are not related to this PR.

@ninamiolane ninamiolane merged commit 8d603a0 into geomstats:master Aug 11, 2022
@ninamiolane ninamiolane deleted the elastic-geod branch August 11, 2022 17:04
@ninamiolane ninamiolane mentioned this pull request Aug 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned 4964
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ninamiolane
0