8000 AAC: save last X by annacalissano · Pull Request #1648 · geomstats/geomstats · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

AAC: save last X #1648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 19, 2022
Merged

AAC: save last X #1648

merged 2 commits into from
Sep 19, 2022

Conversation

annacalissano
Copy link
Collaborator

…o be able to access the last permuted dataset.

Checklist

  • My pull request has a clear and explanatory title.
  • If neccessary, my code is vectorized.
  • I have added apropriate unit tests.
  • I have made sure the code passes all unit tests. (refer to comment below)
  • My PR follows PEP8 guidelines. (refer to comment below)
  • My PR follows geomstats coding style and API.
  • My code is properly documented and I made sure the documentation renders properly. (Link)
  • I have linked to issues and PRs that are relevant to this PR.

Description

Issue

Additional context

adding the self.aligned_X_ attribute to all aac functions as I need t…
76a00f2 
…o be able to access the last permuted dataset.
@annacalissano annacalissano changed the title adding the self.aligned_X_ attribute to all aac functions as I need t… AAC: save last X Sep 19, 2022
@codecov
Copy link
codecov bot commented Sep 19, 2022 •
edited
Loading

Codecov Report

Merging #1648 (76a00f2) into master (30b45d3) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 76a00f2 differs from pull request most recent head 241d87a. Consider uploading reports for the commit 241d87a to get more accurate results

@@            Coverage Diff             @@
##           master    #1648      +/-   ##
==========================================
+ Coverage   90.31%   90.34%   +0.03%     
==========================================
  Files         115      115              
  Lines       11465    11476      +11     
==========================================
+ Hits        10354    10367      +13     
+ Misses       1111     1109       -2
Flag Coverage Δ
numpy 88.30% <100.00%> (+0.04%) ⬆️
tensorflow 74.37% <45.46%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
geomstats/learning/aac.py 98.40% <100.00%> (+0.16%) ⬆️
geomstats/geometry/stratified/wald_space.py 90.22% <0.00%> (+0.86%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@luisfpereira luisfpereira merged commit 732ec91 into geomstats:master Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annacalissano @luisfpereira
0