8000 Add Klein bottle by jubrau · Pull Request #1707 · geomstats/geomstats · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add Klein bottle #1707

New issue
Jump to bottom
Merged
merged 22 commits into from
Feb 5, 2024
Merged

Add Klein bottle #1707

merged 22 commits into from
Feb 5, 2024

Conversation

jubrau
Copy link
Contributor
@jubrau jubrau commented Oct 20, 2022

Checklist

  • My pull request has a clear and explanatory title.
  • If neccessary, my code is vectorized.
  • I have added apropriate unit tests.
  • I have made sure the code passes all unit tests. (refer to comment below)
  • My PR follows PEP8 guidelines. (refer to comment below)
  • My PR follows geomstats coding style and API.
  • My code is properly documented and I made sure the documentation renders properly. (Link)
  • I have linked to issues and PRs that are relevant to this PR.

Description

This pull request provides an implementation of the Klein Bottle.

Additional context

The class KleinBottleMetricTestData overwrites the function log_after_exp_test_data of _RiemannianMetricTestData, since the implementation of sampling tangent vectors with length smaller than the injectivity radius was not correct. The new implementation is general and could replace the implementation in _RiemannianMetricTestData.

jubrau added 12 commits October 18, 2022 18:17
@codecov
Copy link
codecov bot commented Oct 20, 2022 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f7629e5) 91.59% compared to head (5f04c6d) 91.65%.

Files Patch % Lines
geomstats/geometry/klein_bottle.py 97.71% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1707      +/-   ##
==========================================
+ Coverage   91.59%   91.65%   +0.07%     
==========================================
  Files         148      149       +1     
  Lines       13537    13624      +87     
==========================================
+ Hits        12398    12486      +88     
+ Misses       1139     1138       -1
Flag Coverage Δ
autograd 87.65% <97.71%> (+0.06%) ⬆️
numpy 90.35% <97.71%> (+0.09%) ⬆️
pytorch 85.59% <97.71%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jubrau jubrau changed the title Implement Klein bottle Add Klein bottle Oct 20, 2022
@luisfpereira luisfpereira self-requested a review November 17, 2022 09:40
@luisfpereira
Copy link
Collaborator

Hi @jubrau! First of all, thanks for the nice contribution. I'm making small changes to make it more consistent with the other spaces. I'll come back to you soon to clarify some points.

@luisfpereira luisfpereira requested review from ninamiolane and removed request for luisfpereira February 5, 2024 21:54
ninamiolane
ninamiolane approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator
@ninamiolane ninamiolane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thank you so much!

@ninamiolane ninamiolane merged commit ef340b9 into geomstats:main Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninamiolane ninamiolane ninamiolane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jubrau @luisfpereira @ninamiolane
0