8000 Geomvizhwmodified by AlirezaParsay · Pull Request #1826 · geomstats/geomstats · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Geomvizhwmodified #1826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Geomvizhwmodified #1826

wants to merge 5 commits into from

Conversation

AlirezaParsay
Copy link
Collaborator

Checklist

  • My pull request has a clear and explanatory title.
  • If necessary, my code is vectorized.
  • I added appropriate unit tests.
  • I made sure the code passes all unit tests. (refer to comment below)
  • My PR follows PEP8 guidelines. (refer to comment below)
  • My PR follows geomstats coding style and API.
  • My code is properly documented and I made sure the documentation renders properly. (Link)
  • I linked to issues and PRs that are relevant to this PR.

Description

Issue

Additional context

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@codecov
Copy link
codecov bot commented Feb 7, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0.90909% with 109 lines in your changes missing coverage. Please review.

Project coverage is 90.74%. Comparing base (6f37453) to head (6f69525).
Report is 1213 commits behind head on main.

Files Patch % Lines
geomstats/visualization/discrete_curves.py 0.00% 109 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1826      +/-   ##
==========================================
- Coverage   91.50%   90.74%   -0.75%     
==========================================
  Files         136      137       +1     
  Lines       13738    13849     +111     
==========================================
- Hits        12569    12566       -3     
- Misses       1169     1283     +114
Flag Coverage Δ
autograd 86.66% <0.91%> (-0.75%) ⬇️
numpy 86.32% <0.91%> (-0.78%) ⬇️
pytorch 79.80% <0.91%> (-0.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ninamiolane
ninamiolane requested changes Feb 15, 2023
View reviewed changes
Copy link
Collaborator
@ninamiolane ninamiolane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is redundant with the PR #1814.

@AlirezaParsay close PR 1814 if it is outdated, and only keeps this one.
However, look at my code review which has been done on PR 1814 and address its comments here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninamiolane ninamiolane ninamiolane requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
ece594n
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlirezaParsay @ninamiolane
0