8000 Freeze black version due to breaking updates by luisfpereira · Pull Request #1827 · geomstats/geomstats · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Freeze black version due to breaking updates #1827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2023
Merged

Freeze black version due to breaking updates #1827

merged 1 commit into from
Feb 8, 2023

Conversation

luisfpereira
Copy link
Collaborator

Version 23.1.0 of black behaves very differently than previous one (e.g. "would reformat" message).

For now it is better to keep using previous one.

@codecov
Copy link
codecov bot commented Feb 8, 2023 •
edited
Loading

Codecov Report

Merging #1827 (64cfb40) into master (39a6872) will increase coverage by 1.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1827      +/-   ##
==========================================
+ Coverage   90.19%   91.45%   +1.26%     
==========================================
  Files         130      136       +6     
  Lines       13320    13740     +420     
==========================================
+ Hits        12013    12564     +551     
+ Misses       1307     1176     -131
Flag Coverage Δ
autograd 87.41% <ø> (?)
numpy 87.03% <ø> (-0.03%) ⬇️
pytorch 80.46% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
geomstats/geometry/stratified/wald_space.py 87.66% <0.00%> (-1.70%) ⬇️
geomstats/_backend/autograd/linalg.py 96.52% <0.00%> (ø)
geomstats/_backend/autograd/__init__.py 97.71% <0.00%> (ø)
geomstats/_backend/autograd/_common.py 90.91% <0.00%> (ø)
geomstats/_backend/autograd/autodiff.py 87.50% <0.00%> (ø)
geomstats/_backend/autograd/random.py 100.00% <0.00%> (ø)
geomstats/_backend/autograd/_dtype.py 95.66% <0.00%> (ø)
geomstats/information_geometry/dirichlet.py 93.69% <0.00%> (+0.36%) ⬆️
geomstats/learning/expectation_maximization.py 80.45% <0.00%> (+0.56%) ⬆️
geomstats/geometry/sub_riemannian_metric.py 94.12% <0.00%> (+0.99%) ⬆️
... and 9 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ninamiolane ninamiolane merged commit b52a21a into geomstats:master Feb 8, 2023
@luisfpereira luisfpereira deleted the black-version branch February 9, 2023 08:27
@ninamiolane ninamiolane mentioned this pull request Feb 15, 2023
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninamiolane ninamiolane ninamiolane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luisfpereira @ninamiolane
0