8000 Add centre and scale to DiscreteCurves projection by monsij · Pull Request #1832 · geomstats/geomstats · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add centre and scale to DiscreteCurves projection #1832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add centre and scale to DiscreteCurves projection #1832

wants to merge 2 commits into from

Conversation

monsij
Copy link
Collaborator
@monsij monsij commented Mar 2, 2023

Checklist

  • My pull request has a clear and explanatory title.
  • If necessary, my code is vectorized.
  • I added appropriate unit tests.
  • I made sure the code passes all unit tests. (refer to comment below)
  • My PR follows PEP8 guidelines. (refer to comment below)
  • My PR follows geomstats coding style and API.
  • My code is properly documented and I made sure the documentation renders properly. (Link)
  • I linked to issues and PRs that are relevant to this PR.

Description

Added centering and scaling capabilities to DiscreteCurves. The constructor accepts centre=False and scale=False so that we are able to distinguish between object and preshape space.

Issue

Additional context

@monsij monsij changed the title Add centre and scale to DiscreteCurves.projection( ) Add centre and scale to DiscreteCurves projection Mar 2, 2023
@codecov
Copy link
codecov bot commented Mar 2, 2023 •
edited
Loading

Codecov Report

Merging #1832 (f5abde1) into master (cfb31bf) will increase coverage by 3.12%.
The diff coverage is 26.67%.

@@            Coverage Diff             @@
##           master    #1832      +/-   ##
==========================================
+ Coverage   86.79%   89.90%   +3.12%     
==========================================
  Files         124      130       +6     
  Lines       12452    13158     +706     
==========================================
+ Hits        10806    11828    +1022     
+ Misses       1646     1330     -316
Flag Coverage Δ
numpy 86.69% <26.67%> (-0.09%) ⬇️
pytorch 80.13% <26.67%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
geomstats/geometry/discrete_curves.py 90.00% <26.67%> (-1.46%) ⬇️
geomstats/geometry/positive_reals.py 93.48% <0.00%> (-2.17%) ⬇️
geomstats/learning/expectation_maximization.py 79.89% <0.00%> (-0.55%) ⬇️
geomstats/geometry/stratified/wald_space.py 89.79% <0.00%> (-0.42%) ⬇️
geomstats/_backend/pytorch/autodiff.py 93.43% <0.00%> (ø)
geomstats/_backend/pytorch/random.py 92.60% <0.00%> (ø)
geomstats/_backend/pytorch/_dtype.py 93.55% <0.00%> (ø)
geomstats/_backend/pytorch/_common.py 100.00% <0.00%> (ø)
geomstats/_backend/pytorch/linalg.py 86.67% <0.00%> (ø)
geomstats/_backend/pytorch/__init__.py 96.63% <0.00%> (ø)
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@monsij monsij marked this pull request as ready for review March 6, 2023 07:21
@luisfpereira luisfpereira added the geometry geometry related content label Jul 11, 2023
@luisfpereira
Copy link
Collaborator

Closing as it needs to be rethought after changes in #1904.
7B37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
geometry geometry related content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@monsij @luisfpereira
0