Add Diffeo abstraction #1863
Closed
Add Diffeo abstraction #1863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ninamiolane, I would like to move on with this idea as we are bringing in several |
|
@luisfpereira I just looked, and the design seems coherent with our last discussions on this subject. I am on holiday, and I will be back on the 1st of August and will be available for review if you need me. I did not see your previous invitation; I think it has expired. |
ymontmarin
reviewed
Aug 4, 2023
| ): | ||
| self._check_ambient_manifold(space.ambient_manifold) | ||
|
|
||
| diffeo = FTransform( |
There was a problem hiding this comment.
The reading is simple, it is great
Merged
|
Closing as new version as been developed more carefully and thoroughly in #1904. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the notion of
Diffeo. This intends to simplifyPullbackDiffeoMetric, as well as make it more logically sound (both mathematically and computationally).In the current implementation everything that is related with the diffeomorphism (meaning moving points and tangent vectors from one space to the other, in both directions) is implemented within
PullbackDiffeoMetric. I argue these operations can live by themselves and are independent ofPullbackDiffeoMetric(this PR moves them to a new class calledDiffeo). On the other hand,PullbackDiffeoMetricneeds access to this object.I've changed the code in
UnivariateNormalMetric(may interest you @alebrigant and @tramy1258), andElasticMetricandSRVMetric(may interest you @alebrigant) to be according to my proposal.This also simplifies testing, as
PullbackDiffeoMetriconly defines methods that we clearly associate to a metric (exp,log,dist, etc), and nothing related with point transformations.I think this also interests you @ymontmarin.
This is just a prototype (I haven't changed the tests yet, so their failing). Looking forward for your feedback.