8000 Fixes and improvements coming from test refactoring (part 4) by luisfpereira · Pull Request #1885 · geomstats/geomstats · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixes and improvements coming from test refactoring (part 4) #1885

New issue
8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 27, 2023
Merged

Fixes and improvements coming from test refactoring (part 4) #1885

merged 9 commits into from
Oct 27, 2023

Conversation

luisfpereira
Copy link
Collaborator

Follows #1848. It consists of several small fixes that intend to make the library more consistent and remove bugs. Most of these fixes were identified while developing #1767.

@codecov
Copy link
codecov bot commented Sep 6, 2023 •
edited
Loading

Codecov Report

Merging #1885 (eb55b3b) into master (2eeee17) will decrease coverage by 3.78%.
Report is 12 commits behind head on master.
The diff coverage is 85.83%.

❗ Current head eb55b3b differs from pull request most recent head eaac31f. Consider uploading reports for the commit eaac31f to get more accurate results

@@            Coverage Diff             @@
##           master    #1885      +/-   ##
==========================================
- Coverage   90.70%   86.92%   -3.78%     
==========================================
  Files         140      135       -5     
  Lines       13071    13006      -65     
==========================================
- Hits        11855    11304     -551     
- Misses       1216     1702     +486
Flag Coverage Δ
autograd 86.92% <85.83%> (-0.08%) ⬇️
numpy ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
geomstats/geometry/base.py 89.56% <ø> (ø)
geomstats/geometry/complex_matrices.py 92.50% <100.00%> (+0.64%) ⬆️
geomstats/geometry/complex_poincare_disk.py 100.00% <100.00%> (ø)
geomstats/geometry/general_linear.py 98.60% <100.00%> (+0.07%) ⬆️
geomstats/geometry/hermitian_matrices.py 93.26% <100.00%> (+1.11%) ⬆️
geomstats/geometry/lower_triangular_matrices.py 96.67% <100.00%> (ø)
geomstats/geometry/manifold.py 91.94% <100.00%> (+0.14%) ⬆️
geomstats/geometry/poincare_ball.py 96.16% <100.00%> (+0.77%) ⬆️
...ats/geometry/positive_lower_triangular_matrices.py 100.00% <100.00%> (ø)
geomstats/geometry/product_manifold.py 86.96% <ø> (ø)
... and 19 more

... and 17 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@luisfpereira luisfpereira mentioned this pull request Oct 24, 2023
Merged
@luisfpereira luisfpereira marked this pull request as ready for review October 24, 2023 21:26
@luisfpereira luisfpereira mentioned this pull request Oct 24, 2023
Merged
ninamiolane
ninamiolane requested changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator
@ninamiolane ninamiolane left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YESSSS! Excited for this. There is the linting error on the numerics file and some testing errors that should be fixed.

@luisfpereira luisfpereira merged commit 1d23db2 into geomstats:master Oct 27, 2023
luisfpereira added a commit that referenced this pull request Oct 27, 2023
@luisfpereira
Merge pull request #1895 from luisfpereira/master-all
3b3e5a1 
Merge #1767, #1885, #1890, and #1894 together
@luisfpereira luisfpereira deleted the fixes-from-tests branch November 10, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninamiolane ninamiolane ninamiolane requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luisfpereira @ninamiolane
0