8000 Improve Siegel inner_product computation by YannCabanes · Pull Request #1892 · geomstats/geomstats · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve Siegel inner_product computation #1892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 2, 2023
Merged

Improve Siegel inner_product computation #1892

merged 4 commits into from
Nov 2, 2023

Conversation

YannCabanes
Copy link
Collaborator

Improve Siegel inner_product computation noting that:

<v, w>_{O}
= 1/2 * trace((I - O O^{H})^{-1} v (I - O^{H} O)^{-1} w^{H})
+ 1/2 * trace((I - O O^{H})^{-1} w (I - O^{H} O)^{-1} v^{H})
= Re(trace((I - O O^{H})^{-1} v (I - O^{H} O)^{-1} w^{H}))

Indeed,

  trace((I - O O^{H})^{-1} w (I - O^{H} O)^{-1} v^{H})
= trace(w (I - O^{H} O)^{-1} v^{H} (I - O O^{H})^{-1})  #Trace commutativity
= trace(((I - O O^{H})^{-1} v (I - O^{H} O)^{-1} w^{H})^{H})
= conjugate(trace((I - O O^{H})^{-1} v (I - O^{H} O)^{-1} w^{H}))

@codecov
Copy link
codecov bot commented Oct 13, 2023 •
edited
Loading

Codecov Report

Merging #1892 (16e11af) into master (3b3e5a1) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1892      +/-   ##
==========================================
+ Coverage   91.17%   91.23%   +0.06%     
==========================================
  Files         226      226              
  Lines       19584    19580       -4     
==========================================
+ Hits        17854    17861       +7     
+ Misses       1730     1719      -11
Flag Coverage Δ
autograd 88.09% <100.00%> (+0.01%) ⬆️
numpy 89.76% <100.00%> (+0.05%) ⬆️
pytorch 86.49% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
geomstats/geometry/siegel.py 98.97% <100.00%> (-0.02%) ⬇️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@YannCabanes
Copy link
Collaborator Author

Hello @luisfpereira,
Could you review this PR please?

@luisfpereira luisfpereira self-requested a review October 14, 2023 07:49
@YannCabanes
Copy link
Collaborator Author

Hello @luisfpereira and @ninamiolane,
Could you merge this PR please?

@luisfpereira
Copy link
Collaborator

Thanks @YannCabanes!

@luisfpereira luisfpereira merged commit 4d0ff59 into geomstats:master Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisfpereira luisfpereira luisfpereira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YannCabanes @luisfpereira
0