Refactor DiscreteSurfaces (part 1) #1958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1958 +/- ##
==========================================
- Coverage 91.63% 85.55% -6.08%
==========================================
Files 150 140 -10
Lines 13599 13351 -248
==========================================
- Hits 12460 11421 -1039
- Misses 1139 1930 +791
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0f5f76b to
0fe220a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
DiscreteSurfaces, in particular the operations that are required to compute path energy (i.e. all the methods inner product calls).Vectorization is fully fixed. Performance is hugely increased. Correctness of inner product computation was verified against original code (https://github.com//emmanuel-hartman/H2_SurfaceMatch).
Next steps consist on improving exp and log solvers. #1957 already starts this (for the log). (NB: this PR does not address them at all, meaning they're still slow.)