Use aligner abstraction within fiber bundle and rely on group action on total space #1978
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1978 +/- ##
==========================================
+ Coverage 92.10% 92.25% +0.16%
==========================================
Files 158 155 -3
Lines 14442 13936 -506
==========================================
- Hits 13300 12855 -445
+ Misses 1142 1081 -61
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b2d525d to
c798204
Compare
…up action abstraction
c798204 to
dea67aa
Compare
|
@ninamiolane, I'm merging because, as we've discussed in our last meeting, the API becomes much cleaner (we need with some urgency for discrete curves). There's some naming we may need to improve regarding the group action (let's take a look again to it at some point). |
This PR updates
FiberBundleto:use an
AlignerAlgorithm: follows what was already being done in discrete curves and graph space (notice the abstraction was initially defined within the graph space context)definitely moves
group_actionto the total space by removing it from fiber bundleFor 1., the main advantages are i) an easier control of the numerical parameters, ii) homogenization of the code among all the uses of quotient spaces (including graph space), iii) it becomes easier and more natural to plugin different aligner algorithms (this has already being taken advantage of within discrete curves).
For 2., we use
space.equip_with_group_actionmethod and make everything consistent, i.e. a group action endows the total space. Notice that a group action can simply be a callable (see e.g.full_rank_correlation_matrices.CorrelationMatricesBundle) or a child ofGroupAction. The aligner algorithm works with just a little extra information regarding group dimensionality.