Fix: Pass through keyword args for create_geospatial_table(). Fixes: #532 #533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f8c253f to
8dae5a1
Compare
|
Thanks for this work @jurgispods ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Alembic helpers registering a
create_geospatial_tableoperation did not pass additional keyword arguments to the operation. Additional user-provided arguments likepostgres_partition_bywould therefore get lost when using thegeoalchemy2.alembic_helpers.writerhelper function. Fixes: #532Checklist
This pull request is:
Fixes: #<issue number>in the description if it solves an existing issue(which must include a complete example of the issue).
mainbranch and pass with the provided fix.Fixes: #<issue number>in the description if it solves an existing issue(which must include a complete example of the feature).