8000 Fix warnings about "on" symbols in GeoExt.data.store.Layers by geographika · Pull Request #721 · geoext/geoext · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix warnings about "on" symbols in GeoExt.data.store.Layers #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2022
Merged

Fix warnings about "on" symbols in GeoExt.data.store.Layers #721

merged 1 commit into from
Dec 16, 2022

Conversation

geographika
Copy link
Member

The on events were removed in newer versions of OpenLayers (they were present in 4.6.5 - https://openlayers.org/en/v4.6.5//apidoc/ol.Collection.html#on but not in the latest OL versions).
In the latest mster version of GeoExt I get the following warnings. This pull request removes the symbols as I don't believe they are now required.

 [W] The class "GeoExt.data.store.Layers" depends on the external symbol "ol.Collection.prototype.on", which does not seem to exist.
 [W] The class "GeoExt.data.store.Layers" depends on the external symbol "ol.layer.Layer.prototype.on", which does not seem to exist.

marcjansen
marcjansen approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member
@marcjansen marcjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests and manual examples work without them, so I think you are right.

Thanks and please merge.

@geographika geographika merged commit 42a08b3 into geoext:master Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcjansen marcjansen marcjansen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geographika @marcjansen
0