Fix CI resource copying/referencing (aftermath of ol upgrade) #723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current CI step is broken as the search and replace action in geoext@a5f3348#diff-06f983058dae83465098c90797cf428d495b8b4e085d07208e61be17203873c0R105-R106 has made the `sed` expression invalid. This commit changes the CI step so that the files `dist/ol.js` and `dist/ol.js.map` and `ol.css` should be reachable from `master/resources` and the references in the example HTML-files should correctly point to these files.
KaiVolland
approved these changes
Dec 16, 2022
hwbllmnn
approved these changes
Dec 16, 2022
|
Thanks for the prompt reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current CI step is broken as the search and replace action in a5f3348#diff-06f983058dae83465098c90797cf428d495b8b4e085d07208e61be17203873c0R105-R106 has made the
sedexpression invalid.This commit changes the CI step so that the files
dist/ol.jsanddist/ol.js.mapandol.cssshould be reachable frommaster/resourcesand the references in the example HTML-files should correctly point to these files.Again, this is something that can be best tested once merged.
Please review @geoext/dev