[Cloud Directory] added schema endpoints #8915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8915 +/- ##
==========================================
- Coverage 92.85% 92.85% -0.01%
==========================================
Files 1287 1287
Lines 112583 112663 +80
==========================================
+ Hits 104539 104612 +73
- Misses 8044 8051 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…bo/moto into feature/clouddirectory
bblommers
approved these changes
Jun 7, 2025
There was a problem hiding this comment.
This looks great - thank you for adding support for these endpoints to Moto @leslieetubo!
| raise ResourceNotFoundException(schema_arn) | ||
| return | ||
|
|
||
| @paginate(pagination_model=PAGINATION_MODEL) |
There was a problem hiding this comment.
Nice to see pagination built-in from the beginning!
|
|
||
| non_existent_schema_arn = f"arn:aws:clouddirectory:{region}:{DEFAULT_ACCOUNT_ID}:schema/development/nonexistent" | ||
|
|
||
| with pytest.raises(client.exceptions.ResourceNotFoundException): |
There was a problem hiding this comment.
Nice to see negative tests as well, having proper error handling helps users a lot during development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainers and Reviewers @bblommers and @bpandola.
This PR adds some endpoints to Cloud Directory Service. To create a cloud directory, a published schema ARN needs to be passed. When a schema is created, it is in the development state, until it is published. Only then can it be applied, during this process, the schema arn changes. see
Hence the flow:
flowchart TD A[Create Schema] -->|development| C{what state is schema} C -->|development| D[Publish Schema] C -->|published| E[Apply Schema] C -->|applied| F[Nothing to do] D --> B(Create Directory)