8000 Add example by bun919tw · Pull Request #38 · getamis/alice · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add example #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 10, 2020
Merged

Add example #38

merged 4 commits into from
Apr 10, 2020

Conversation

bun919tw
Copy link
Contributor
@bun919tw bun919tw commented Apr 7, 2020 •
edited
Loading

Before submitting a pull request, please make sure the following is done:

Checklist

  • Fork the repository and create your new branch from master.
  • Please mention the name of community in Pull Request title.
  • Git Commit Messages
    • Use the present tense (Also in Pull Request title): "Add feature" not "Added feature"
    • Use the imperative mood (Also in Pull Request title): "Move cursor to..." not "Moves cursor to..."
    • Use rebase to squash/fixup dummy/unnecessary commits into only one commit.

@bun919tw bun919tw force-pushed the add_example branch 2 times, most recently from e9b22f3 to 5df65df Compare April 7, 2020 09:41
@codecov-io
Copy link
codecov-io commented Apr 7, 2020 •
edited
Loading

Codecov Report

Merging #38 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage   87.22%   87.20%   -0.03%     
==========================================
  Files          54       54              
  Lines        3844     3861      +17     
==========================================
+ Hits         3353     3367      +14     
- Misses        277      279       +2     
- Partials      214      215       +1
Impacted Files Coverage Δ
crypto/homo/cl/cl.go 65.37% <0.00%> (+0.04%) ⬆️
crypto/homo/cl/message.go 93.22% <0.00%> (+0.49%) ⬆️
crypto/homo/cl/proof.go 71.90% <0.00%> (+0.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2058f25...0329b68. Read the comment docs.

@StanleyDing
Copy link

Great job on the concise examples.

markya0616
markya0616 reviewed Apr 9, 2020
View reviewed changes
example/node.go
@@ -0,0 +1,121 @@
// Copyright © 2020 AMIS Technologies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can move send() and connect() to pm.go? only peer manager needs these two methods.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put these two functions in node.go because I think they are related to p2p.

8000
markya0616
markya0616 reviewed Apr 9, 2020
View reviewed changes
@yurenju
Copy link
yurenju commented Apr 10, 2020

looks good 😌

markya0616
markya0616 previously approved these changes Apr 10, 2020
View reviewed changes
@bun919tw bun919tw merged commit a648212 into master Apr 10, 2020
@bun919tw bun919tw deleted the add_example branch April 10, 2020 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markya0616 markya0616 markya0616 approved these changes

@cychuang0924 cychuang0924 Awaiting requested review from cychuang0924 cychuang0924 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bun919tw @codecov-io @StanleyDing @yurenju @markya0616
0