Guesstimator lib should not sample with formatting errors, closes issue #188 #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const numbers = this._numbers(text) | ||
| if (numbers.length !== 2) { return ['Must contain 2 inputs'] } | ||
| if (!_.every(numbers, (e) => isParseableNumber(e))) { return ['Not all numbers are parseable'] } | ||
| if (numbers[0] >= numbers[1]) { return ['Low number must be first'] } |
There was a problem hiding this comment.
We should format these like they are for users. So I would say, ['Format must be [low, high]']. Feel free to leave for later.
mmcdermott
added a commit
that referenced
this pull request
Mar 15, 2016
…tion-add Guesstimator lib should not sample with formatting errors, closes issue #188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.