[data][prelude][core] Poll effect + handleFirst #891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwbrasil
commented
Dec 3, 2024
| @@ -0,0 +1,66 @@ | |||
| package kyo | |||
There was a problem hiding this comment.
,oved to the kyo package since it's shared between Emit, Poll, and Stream.
Draft
hearnadam
approved these changes
Dec 5, 2024
| end apply | ||
| end RunFirstOps | ||
|
|
||
| inline def runFirst[V >: Nothing]: RunFirstOps[V] = RunFirstOps(()) |
There was a problem hiding this comment.
I'd prefer to keep a consistent naming with ArrowEffect.handleFirst. The "first" is more about the first suspension than the first element.
| * A computation that processes values until completion | ||
| */ | ||
| def apply[S](f: V => Unit < S)(using tag: Tag[Poll[V]], frame: Frame): Unit < (Poll[V] & S) = | ||
| Loop(()) { _ => |
There was a problem hiding this comment.
Should we add a apply0? Followup is fine.
There was a problem hiding this comment.
I tried some time ago but had inference issues
| ArrowEffect.handleFirst(emitTag, emit)( | ||
| handle = [C] => | ||
| (emitted, emitCont) => | ||
| // Debug.values(emitted) |
| ArrowEffect.handleFirst(pollTag, poll)( | ||
| handle = [C2] => | ||
| (ack, pollCont) => | ||
| // Debug.values(ack) |
| // 2. Pass the emitted value to poller for consumption | ||
| // 3. Recursively continue the cycle | ||
| Loop.continue(emitCont(ack), pollCont(Maybe(emitted))), | ||
| 8000 // Poll.run(emitCont(ack))(pollCont(Maybe(emitted))), |
| Loop.continue(emitCont(ack), pollCont(Maybe(emitted))), | ||
| // Poll.run(emitCont(ack))(pollCont(Maybe(emitted))), | ||
| done = b => | ||
| // Debug.values(b) |
| * @return | ||
| * The transformed computation result | ||
| */ | ||
| inline def handleFirst[I[_], O[_], E <: ArrowEffect[I, O], A, B, S, S2](effectTag: Tag[E], v: A < (E & S))( |
There was a problem hiding this comment.
Effect handling is starting to get interesting!
| Emit.runDiscard(emitCont(Ack.Stop)).map(a => Loop.done((a, b))) | ||
| ), | ||
| done = a => | ||
| // Debug.values(a) |
Co-authored-by: Adam Hearn <22334119+hearnadam@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new
Polleffect that functions as the opposite ofEmit. I've also introducedArrowEffect.handleFirstandEmit.handleFirst, which might be useful for the work on Stream. I'm planning to usePollfor anActorimplementation.