[core] stable fiber identity #1190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steinybot
approved these changes
May 14, 2025
hearnadam
reviewed
May 14, 2025
| end if | ||
| end run | ||
|
|
||
| private inline def nullResult = null.asInstanceOf[A < Ctx & Async & Abort[E]] | ||
|
|
||
| override def toString = | ||
| s"IOTask(state = ${stateString()}, preempt = ${{ shouldPreempt() }}, finalizers = ${finalizers.size()}, curr = ${curr})" | ||
| s"IOTask(id = ${hashCode()}, state = ${stateString()}, preempt = ${{ shouldPreempt() }}, finalizers = ${finalizers.size()}, curr = ${curr})" |
There was a problem hiding this comment.
Do you think we should add an id method?
There was a problem hiding this comment.
I considered exposing it but I haven't seen a good use case yet to justify the API commitment
hearnadam
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When a fiber encounters a child fiber/promise to wait on during execution,
IOTaskcurrently resumes the parent in a newIOTaskinstance after the child completes. Besides the performance cost, this makes the identity of a fiber not stable since it might be executing in a linkedIOTaskinstance if it got suspended by a child fiber. It's a blocker to implement fiber trace dumps for example since the actual execution trace might in a linkedIOTaskinstance.Solution
Adapt the logic to simply resume the
IOTaskafter a child completes and the execution of the parent needs to resume.