8000 [core] add (Stream < S).unwrap by ahoy-jon · Pull Request #1244 · getkyo/kyo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[core] add (Stream < S).unwrap #1244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 10, 2025
Merged

[core] add (Stream < S).unwrap #1244

merged 7 commits into from
Jun 10, 2025

Conversation

ahoy-jon
Copy link
Contributor
@ahoy-jon ahoy-jon commented Jun 7, 2025 •
edited
Loading

add (Stream[V, S1] < S2).unwrap

  • test
  • doc?

@ahoy-jon ahoy-jon force-pushed the feat/unwrap branch 2 times, most recently from d06716b to 87da851 Compare June 7, 2025 10:28
johnhungerford
johnhungerford reviewed Jun 7, 2025
View reviewed changes
@ahoy-jon ahoy-jon requested a review from johnhungerford June 8, 2025 21:11
@ahoy-jon ahoy-jon force-pushed the feat/unwrap branch 2 times, most recently from 26810d5 to 58f6d03 Compare June 8, 2025 21:43
johnhungerford
johnhungerford approved these changes Jun 9, 2025
View reviewed changes
Copy link
Contributor
@johnhungerford johnhungerford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than clarifying README

fwbrasil
fwbrasil reviewed Jun 9, 2025
View reviewed changes
ahoy-jon
ahoy-jon commented Jun 9, 2025
View reviewed changes
hearnadam
hearnadam reviewed Jun 9, 2025
View reviewed changes
@fwbrasil fwbrasil merged commit 16a88ef into getkyo:main Jun 10, 2025
5 of 8 checks passed
@ahoy-jon ahoy-jon deleted the feat/unwrap branch June 10, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hearnadam hearnadam hearnadam left review comments

@johnhungerford johnhungerford johnhungerford approved these changes

@fwbrasil fwbrasil Awaiting requested review from fwbrasil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahoy-jon @fwbrasil @hearnadam @johnhungerford
0