Abort: remove usage of erased Tags #1333
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steinybot
reviewed
Jul 5, 2025
There was a problem hiding this comment.
LGTM although AbortCombinatorsTest.abort.forAbort.mapAbort.should map single Abort seems to be failing with:
[info] - should map single Abort *** FAILED *** (8 milliseconds)
[info] kyo.bug$KyoBugException: BUG Unexpected pending effect while handling scala.Any: Kyo(kyo.Abort[-(scala.Boolean | scala.Int | java.lang.String)], Input(Failure(failure)), AbortCombinatorsTest.scala:566:48, assert(effect1Mapped.result) Please open an issue 🥹 https://github.com/getkyo/kyo/issues
[info] at kyo.bug$KyoBugException$.apply(data.scala:14)
[info] at kyo.bug$.apply(data.scala:26)
[info] at kyo.kernel$package$.failTag(kernel.scala:36)
[info] at kyo.kernel.Pending$package$$less$.inline$failTag$i1(Pending.scala:20)
[info] at kyo.AbortCombinatorsTest.evalLoop$65(AbortCombinatorsTest.scala:74)
[info] at assert(effect1Mapped.result.eval @ kyo.AbortCombinatorsTest.?(AbortCombinatorsTest.scala:566)
[info] at kyo.AbortCombinatorsTest.$init$$$anonfun$2$$anonfun$14$$anonfun$2$$anonfun$1(AbortCombinatorsTest.scala:566)
[info] at org.scalatest.freespec.AsyncFreeSpecLike.transformToOutcomeParam$1(AsyncFreeSpecLike.scala:148)
[info] at org.scalatest.freespec.AsyncFreeSpecLike.registerTestToRun$$anonfun$1(AsyncFreeSpecLike.scala:149)
[info] at org.scalatest.AsyncTestSuite.transformToOutcome$$anonfun$1(AsyncTestSuite.scala:240)
[info] ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1247
Problem
Erased tags are leftover from earlier limitations with splicing and subtype checking of tags.
Solution
Require tag evidences in all Abort methods.
Notes
Frameto the first implicit for consistency where possible, but we can followup for the rest.