scheduler: fix console top to show deltas #399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hearnadam
approved these changes
May 21, 2024
|
|
||
| if (enableTopConsoleMs > 0) | ||
| timer.schedule(enableTopConsoleMs.millis) { | ||
| println(Top.print(status())) | ||
| val currentStatus = status() | ||
| if (lastConsoleStatus != null) { |
|
|
||
| if (enableTopConsoleMs > 0) | ||
| timer.schedule(enableTopConsoleMs.millis) { | ||
| println(Top.print(status())) | ||
| val currentStatus = status() |
There was a problem hiding this comment.
I assume status() will never return null?
If not, should we have a Status.empty to prevent gaps in reporting? That would prevent the need for null on line 27 as well.
There was a problem hiding this comment.
I'm not sure there's much value in reporting the initial measurement since it'd present accumulated counters up to the point when the observation started.
There was a problem hiding this comment.
Right, wasn't sure if status could also be null for any other reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.