8000 Adds unit tests for utils.py module by JayjeetAtGithub · Pull Request #719 · getpopper/popper · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adds unit tests for utils.py module #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2019
Merged

Adds unit tests for utils.py module #719

merged 2 commits into from
Jul 23, 2019

Conversation

JayjeetAtGithub
Copy link
Collaborator
@JayjeetAtGithub JayjeetAtGithub commented Jul 19, 2019 •
edited
Loading

Add unit tests for utils.py module.

@pep8speaks
Copy link
pep8speaks commented Jul 19, 2019 •
edited
Loading

Hello @JayjeetAtGithub! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-07-23 03:46:07 UTC

@codecov
Copy link
codecov bot commented Jul 19, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@f883568). Click here to learn what that means.
The diff coverage is 99.01%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #719   +/-   ##
=========================================
  Coverage          ?   84.58%           
=========================================
  Files             ?        7           
  Lines             ?      532           
  Branches          ?        0           
=========================================
  Hits              ?      450           
  Misses            ?       82           
  Partials          ?        0
Impacted Files Coverage Δ
cli/popper/utils.py 83.03% <100%> (ø)
cli/test/test_utils.py 98.97% <98.97%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f883568...1648d0e. Read the comment docs.

@JayjeetAtGithub JayjeetAtGithub marked this pull request as ready for review July 20, 2019 08:44
@JayjeetAtGithub JayjeetAtGithub requested a review from ivotron July 21, 2019 18:15
ivotron
ivotron requested changes Jul 22, 2019
View reviewed changes
Copy link
Collaborator
@ivotron ivotron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @JayjeetAtGithub, this looks great! Can we add a badge to the README? looks like the URL is https://codecov.io/gh/systemslab/popper/branch/master/graph/badge.svg . Thanks!

@JayjeetAtGithub JayjeetAtGithub requested a review from ivotron July 23, 2019 04:36
@ivotron ivotron merged commit 69ee28f into master Jul 23, 2019
@ivotron ivotron deleted the jayjeet/utils_test branch July 23, 2019 05:25
ivotron pushed a commit that referenced this pull request Jul 23, 2019
@JayjeetAtGithub @ivotron
adds unit tests for utils.py module (#719)
e12243d 
Also adds codecov badge to README.

part of #648
ivotron pushed a commit that referenced this pull request May 24, 2020
@JayjeetAtGithub @ivotron
adds unit tests for utils.py module (#719)
7212c8d 
Also adds codecov badge to README.

part of #648
ivotron pushed a commit that referenced this pull request May 25, 2020
@JayjeetAtGithub @ivotron
adds unit tests for utils.py module (#719)
0d3f256 
Also adds codecov badge to README.

part of #648
ivotron pushed a commit that referenced this pull request May 25, 2020
@JayjeetAtGithub @ivotron
adds unit tests for utils.py module (#719)
237c455 
Also adds codecov badge to README.

part of #648
ivotron pushed a commit that referenced this pull request May 25, 2020
@JayjeetAtGithub @ivotron
adds unit tests for utils.py module (#719)
7b06206 
Also adds codecov badge to README.

part of #648
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivotron ivotron ivotron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JayjeetAtGithub @pep8speaks @ivotron
0