8000 chore: Swap out integration test in release pipeline by schristoff · Pull Request #2981 · getporter/porter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: Swap out integration test in release pipeline #2981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 5, 2024
Merged

chore: Swap out integration test in release pipeline #2981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cf80d91
squash
schristoff Feb 5, 2024
0e6d636
add env var to be able to run single files through mage testinteg
schristoff Feb 5, 2024
6ac318c
remove +
schristoff Feb 5, 2024
714c88c
spell
schristoff Feb 5, 2024
beee8eb
please dont turn off
schristoff Feb 5, 2024
11e03e3
forgot about the last test not being in the workflow :(
schristoff Feb 5, 2024
898e861
This will break everything
schristoff Feb 5, 2024
6dda604
chore: swap out integration in release pipeline
schristoff Feb 5, 2024
11f31df
Merge branch 'main' into schristoff_ghavariables
schristoff Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 3 additions & 25 deletions .github/workflows/build_pipelinesrelease_template.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,34 +91,12 @@ jobs:
run: mage TestUnit
shell: bash
Validate-integration_test:
env:
GHCR_IOGETPORTER_DOCKER_REGISTRY: ${{inputs.registry}}
GHCR_IOGETPORTER_DOCKER_USERNAME: getporterbot
name: Integration Test
needs:
- Validate-build
runs-on: ubuntu-latest
steps:
- name: checkout
uses: actions/checkout@v4.1.0
- uses: actions/setup-go@v4
with:
go-version: "${{ inputs.GOVERSION }}"
- name: Download Bin
uses: actions/download-artifact@v4.1.0
with:
name: build-bin
path: bin
- name: Docker Login
uses: docker/login-action@v3.0.0
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
- name: Configure Agent
run: go run mage.go ConfigureAgent SetBinExecutable
- name: Integration Test
run: mage -v TestIntegration
uses: "./.github/workflows/porter-integration.yml"
with:
registry: ${{inputs.registry}}
Validate-smoke_test:
name: Run smoke tests on
needs:
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/integ-reuseable-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ on:
test_name:
type: string
required: false
registry:
type: string
required: false
env:
GOVERSION: 1.20.7
PORTER_INTEG_FILE: ${{inputs.test_name}}.go
Expand All @@ -30,7 +33,7 @@ jobs:
- name: Docker Login
uses: docker/login-action@v3.0.0
with:
registry: ghcr.io
registry: ${{inputs.registry}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here, do we need to log in to the registry to build the images?

username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
- name: Configure Agent
Expand Down
33 changes: 30 additions & 3 deletions .github/workflows/porter-integration.yml
View file
Open in desktop
6D40
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,13 @@ on:
paths-ignore:
- 'docs/**'

workflow_call:
inputs:
registry:
type: string
required: false
default: ghcr.io
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be scoped to ghcr.io/getporter/porter ?


env:
GOVERSION: 1.20.7

Expand All @@ -14,83 +21,103 @@ jobs:
uses: getporter/porter/.github/workflows/integ-reuseable-workflow.yml@main
with:
test_name: archive_test
registry: ${{inputs.registry}}
build_integration_test:
uses: getporter/porter/.github/workflows/integ-reuseable-workflow.yml@main
with:
test_name: build_test
registry: ${{inputs.registry}}
cli_integration_test:
uses: getporter/porter/.github/workflows/integ-reuseable-workflow.yml@main
with:
test_name: cli_test
registry: ${{inputs.registry}}
connection_nix_integration_test:
uses: getporter/porter/.github/workflows/integ-reuseable-workflow.yml@main
with:
test_name: connection_nix_test
registry: ${{inputs.registry}}
copy_integration_test:
uses: getporter/porter/.github/workflows/integ-reuseable-workflow.yml@main
with:
test_name: copy_test
test_name: copy_tests
registry: ${{inputs.registry}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary for each stage of the pipeline if it is not using it?

dependenciesv1_integration_test:
uses: getporter/porter/.github/workflows/integ-reuseable-workflow.yml@main
with:
test_name: dependenciesv1_test
registry: ${{inputs.registry}}
dependenciesv2_integration_test:
uses: getporter/porter/.github/workflows/integ-reuseable-workflow.yml@main
with:
test_name: dependenciesv2_test
registry: ${{inputs.registry}}
driver_integration_test:
uses: getporter/porter/.github/workflows/integ-reuseable-workflow.yml@main
with:
test_name: driver_test
registry: ${{inputs.registry}}
install_integration_test:
uses: getporter/porter/.github/workflows/integ-reuseable-workflow.yml@main
with:
test_name: install_test
registry: ${{inputs.registry}}
invoke_integration_test:
uses: getporter/porter/.github/workflows/integ-reuseable-workflow.yml@main
with:
test_name: invoke_test
registry: ${{inputs.registry}}
lint_integration_test:
uses: getporter/porter/.github/workflows/integ-reuseable-workflow.yml@main
with:
test_name: lint_test
registry: ${{inputs.registry}}
migration_integration_test:
uses: getporter/porter/.github/workflows/integ-reuseable-workflow.yml@main
with:
test_name: migration_test
registry: ${{inputs.registry}}
outputs_integration_test:
uses: getporter/porter/.github/workflows/integ-reuseable-workflow.yml@main
with:
test_name: outputs_test
registry: ${{inputs.registry}}
publish_integration_test:
uses: getporter/porter/.github/workflows/integ-reuseable-workflow.yml@main
with:
test_name: publish_test
registry: ${{inputs.registry}}
pull_integration_test:
uses: getporter/porter/.github/workflows/integ-reuseable-workflow.yml@main
with:
test_name: pull_test
registry: ${{inputs.registry}}
registry_integration_test:
uses: getporter/porter/.github/workflows/integ-reuseable-workflow.yml@main
with:
test_name: registry_integration_test
registry: ${{inputs.registry}}
schema_integration_test:
uses: getporter/porter/.github/workflows/integ-reuseable-workflow.yml@main
with:
test_name: schema_test
registry: ${{inputs.registry}}
sensitive_data_integration_test:
uses: getporter/porter/.github/workflows/integ-reuseable-workflow.yml@main
with:
test_name: sensitive_data_test
registry: ${{inputs.registry}}
suppress_output_integration_test:
uses: getporter/porter/.github/workflows/integ-reuseable-workflow.yml@main
with:
test_name: suppress_output_test
registry: ${{inputs.registry}}
telemetry_test:
uses: getporter/porter/.github/workflows/integ-reuseable-workflow.yml@main
with:
test_name: telemetry_test
# Reusable workflows only supports 20 jobs
registry: ${{inputs.registry}}
# Reusable workflows only supports 20 jobs
uninstall_test_integ:
runs-on: ubuntu-latest
steps:
Expand All @@ -110,7 +137,7 @@ jobs:
- name: Docker Login
uses: docker/login-action@v3.0.0
with:
registry: ghcr.io
registry: ${{inputs.registry}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to build the docker images in the integration tests? Should this be another workflow after we see that the tests are passing?

username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
- name: Configure Agent
Expand Down
0