Run signing integration test #3135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order parallelize integration tests, the Github workflow doesn't use Mage to run all integration tests directly. Instead each integration test file is run in different jobs, requiring new integration test files to be manually added to the workflow. The integration test for signing images was missing and is added in this PR. Signed-off-by: Kim Christensen <kimworking@gmail.com>
Signed-off-by: Kim Christensen <kimworking@gmail.com>
schristoff
reviewed
Jun 3, 2024
| @@ -124,3 +124,33 @@ jobs: | |||
| PORTER_INTEG_FILE: uninstall_test.go | |||
| run: go run mage.go -v TestIntegration | |||
| shell: bash | |||
| signing_test_integ: | |||
There was a problem hiding this comment.
Should we make another reusable workflow file?
There was a problem hiding this comment.
Didn't even think of that, it would be a great idea. I will update the PR
There was a problem hiding this comment.
Unfortunately it is not possible. The documentation states that it is a maximum of 20 reusable workflows from the top-level workflow file 😢
https://docs.github.com/en/actions/using-workflows/reusing-workflows#limitations
schristoff
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
In order parallelize integration tests, the Github workflow doesn't use Mage to run all integration tests directly. Instead each integration test file is run in different jobs, requiring new integration test files to be manually added to the workflow.
The integration test for signing images was missing and is added in this PR.
For some reason running the Notation and Cosign test in parallel fails on in the Github workflow, so parallelization of those two tests are also disabled.
Related to #2902
Notes for the reviewer
Checklist