Remove the (not thread.is_alive()) assertion #2115
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This assertion apparently has a small chance of failing, possibly by a race condition. It was already skipped on Python 3.13+. Fixes gevent#2111
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2A93
This assertion apparently has a small chance of failing, possibly by a race condition. It was already skipped on Python 3.13+.
Fixes #2111
Having said that, I don't understand the underlying issue. https://github.com/he1pu has posted a testcase in #2111, and the patch does fix his testcase.
FWIW the assertion was originally added in 8622a2b