Add metadata change callbacks #115
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, I have a problem that when I edit metadata properties (in frontmatter, if that matters), then I don't get the right update to the icons. Its one change behind, probably a race condition of some kind or other.
This is a fix for that. It adds callbacks to both the vanilla meta store change event & the dataview one. I don't know if the dataview one is necessary, but another one doesn't hurt. I tested with and without dataview enabled & it worked both times so why not?
Also, I noticed that there are only very broad refresh functions, but is there a way to target only the modified files? That might help with performance