Update docs with new crevice version #1274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This fixes doctests by setting skeptic to the branch in: budziq/rust-skeptic#142 It's a temporary fix because skeptic is no longer maintained.
bff12d5 to
b4eb1bb
Compare
sampullman
commented
Mar 31, 2024
| @@ -71,7 +71,7 @@ keyframe = "1" | |||
| keyframe_derive = "1" | |||
| num-derive = "0.4" | |||
|
|
|||
| skeptic = "0.13" | |||
| skeptic = { git = "https://github.com/Erk-/rust-skeptic.git", branch = "fix-rust-1-77" } | |||
8000
There was a problem hiding this comment.
@a1phyr This is a temp fix so we can keep doctests running in CI until I can find an alternative for skeptic.
I cherry-picked your other CI fixes here to test everything together.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #1084
@nobbele I've been getting back into rust/ggez dev and looking through a few issues for low hanging fruit.
I could be mistaken, but don't think this is possible to solve without significant changes to
crevice, since they hard code crate references in the proc macros.This PR just updates the docs with the latest
creviceversion and adds a few notes in the examples. The issue can probably be closed.