Add ability to set window icon with bytes #1290
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I missed a couple things (updating the icon comment in WindowSetup) and also realized that conf of course needs to be able to be serialized and deserialized. Which can do bytes but I feel like it should be kept human readable. Why is icon in conf anyways? I feel like that's something that usually wouldn't be? Would anyone be opposed of removing it from WindowSetup entirely? I'm not sure where would be best for it if not though. edit: Alternatively WindowSetup could go back to only taking a string and if you want to hardcode an icon we could have set_window_icon still take the WindowIcon type instead that's part of this pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been a while since i've done any programming not sure if this is acceptable or not
fixes #1289