Fix compiling when gamepad feature is disabled #1302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bowarc
reviewed
Jan 15, 2025
Bowarc
reviewed
Jan 15, 2025
004873e to
ed2af0f
Compare
Previously, this would break compilation, because the trait bounds would never be met under this environment. This exposes the dummy object such that it's always met, and just a noop when running without gamepad support.
ed2af0f to
00d97d0
Compare
|
Alright, fixed everything up nicely. Also properly got the warning_copy_implementations error to stop bothering us. |
|
Looks good to me |
a1phyr
requested changes
Jan 20, 2025
| /// Dummy gamepad context, for if the gamepad feature is disabled, to allow trait bounds | ||
| /// to still resolve properly | ||
| #[derive(Debug)] | ||
| pub struct GamepadContext; |
There was a problem hiding this comment.
This structure should have a private field or be marked #[non_exhaustive] to avoid it being trivially constructible. This will probably let you get rid of the #![allow(missing_copy_implementations)].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this would break compilation, because the trait bounds would never be met under this environment. This exposes the dummy object such that it's always met, and just a noop when running without gamepad support.