-
Notifications
You must be signed in to change notification settings - Fork 5
Add JSON schema form visual improvements #4040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7f591aa
to
6a78b98
Compare
It would be nice to have an example in our test schema where array items are objects with a title. Like this: "arrayOfObjectsWithTitle": {
"items": {
"properties": {
"age": {
"type": "number"
},
"name": {
"type": "string"
}
},
"type": "object",
"title": "Array item object",
"description": "Description of array item object"
},
"title": "Array of objects with title",
"type": "array"
}, |
The library mark array items as required for some reason. I would need to check what we can do about it. |
I added an example into the test schema. When an array item has custom title, it's being used without index postfix. If we still want to have index added, I can look into it. It's better to do it in a separate ticket, I think. |
children, | ||
}) => { | ||
return ( | ||
<ArrayFieldItemW direction='row'> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small suggestion - could we have a more descriptive name than ArrayFieldItemW
? I assumed the W
stands for wrapper, but I wasn't sure if the abbreviation was intentional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for noticing, it's definitely unintentional. Will fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well for me 👍 My comment above about the naming shouldn't be blocking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good improvement as it is!
Referencing the original issue: giantswarm/roadmap#1181 |
What does this PR do?
Visual improvements for hierarchical object and array fields according to the design specs.
How does it look like?
Any background context you can provide?
Towards giantswarm/roadmap#1181.