8000 JSON schema form number field improvements by gusevda · Pull Request #4062 · giantswarm/happa · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

JSON schema form number field improvements #4062

New issue
< 8000 div class="px-4">

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 2, 2023
Merged

JSON schema form number field improvements #4062

merged 3 commits into from
Feb 2, 2023

Conversation

gusevda
Copy link
Contributor
@gusevda gusevda commented Feb 2, 2023

What does this PR do?

Our NumberPicker component behaves incorrectly when the input is empty:

  1. the component displays 0 as default value, which could be misleading.
  2. if a user manually clears the input, + and - buttons stop working.

In this PR:

  • the behaviour of NumberPicker component was changed to be more aligned with browser's default <input type="number" /> component.
  • BaseInputTemplate component was fixed to process empty values for number fields.

Any background context you can provide?

Towards giantswarm/roadmap#1181.

@gusevda gusevda requested a review from a team February 2, 2023 09:03
@gusevda gusevda mentioned this pull request Feb 2, 2023
Closed
41 tasks
kuosandys
kuosandys approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor
@kuosandys kuosandys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gusevda gusevda enabled auto-merge (squash) February 2, 2023 14:40
@gusevda gusevda merged commit 1f3f2b7 into main Feb 2, 2023
@gusevda gusevda deleted the json-schema-form-number-field-improvements branch February 2, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuosandys kuosandys kuosandys approved these changes

Assignees

@gusevda gusevda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gusevda @kuosandys
0