Display correct cluster app version #4572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7fd7d00 to
d8bbf16
Compare
mproffitt
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
After recent changes in cluster-aws chart (some values were moved to a separate cluster chart) we display incorrect cluster app version in several places. This is because we take information about cluster app version from
app.kubernetes.io/versionlabel from Cluster resource not from a corresponding provider cluster resource.In this PR, I changed the way we get cluster app version. Now it's being taken from a provider cluster resource (ClusterAWS, ClusterAzure, etc.).
How does it look like?
Screenshots are for CAPA cluster with cluster-aws version 0.58.0
Clusters list before:
Clusters list after:
Cluster details before:
Cluster details after:
Organization details before:
Organization details after:
Any background context you can provide?
Closes https://github.com/giantswarm/giantswarm/issues/29427.