Add support for app bundles installation #3905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuosandys
reviewed
Nov 29, 2022
|
Looks good in general from what I can tell! Thanks for including an explanation of the nuances of app bundle installation. Would we also be adding some tests for app bundle installation to this PR? Also, I know we're just adding support for installation with this PR, but I was wondering if you knew whether we'd also need to adapt app uninstallation/deletion? |
From what I experienced, app bundle deletion works well. But let me double check it. |
kuosandys
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
With the changes from this PR now it is now possible to install app bundles. Differences for an app bundle installation:
app-operator.giantswarm.io/version: 0.0.0label and the.spec.kubeConfig.inClusterfield set totrue..metadata.namespaceand.spec.namespacefields must be equal and reference the cluster namespace on vintage and organization namespace on CAPI.clusterNameandorganizationvalues.What is the effect of this change to users?
App catalog entries that represent app bundles were visible in the UI but their installation were not possible. Now it should work correctly and not cause any errors.
How does it look like?
Unique app name in a context of a workload cluster is suggested and there is a note that emphasis that the name should be unique . There is no namespace field for an app bundle installation form.
We don't additionally validate on the client side that the app name is unique across other workload clusters, but if a user tries to install an app bundle with the name that is already taken, it will fail and an error will be displayed.
Any background context you can provide?
https://github.com/giantswarm/giantswarm/issues/21478