8000 Add support for app bundles installation by gusevda · Pull Request #3905 · giantswarm/happa · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add support for app bundles installation #3905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 7, 2022
Merged

Conversation

gusevda
Copy link
Contributor
@gusevda gusevda commented Nov 24, 2022

What does this PR do?

With the changes from this PR now it is now possible to install app bundles. Differences for an app bundle installation:

  1. App CR instance of an app bundle must be given a unique name within the Management Cluster.
  2. App CR should have app-operator.giantswarm.io/version: 0.0.0 label and the .spec.kubeConfig.inCluster field set to true.
  3. App CR’s .metadata.namespace and .spec.namespace fields must be equal and reference the cluster namespace on vintage and organization namespace on CAPI.
  4. A user configuration to the App CR must provide clusterName and organization values.

What is the effect of this change to users?

App catalog entries that represent app bundles were visible in the UI but their installation were not possible. Now it should work correctly and not cause any errors.

How does it look like?

Unique app name in a context of a workload cluster is suggested and there is a note that emphasis that the name should be unique . There is no namespace field for an app bundle installation form.
Screenshot 2022-11-24 at 11 10 49

We don't additionally validate on the client side that the app name is unique across other workload clusters, but if a user tries to install an app bundle with the name that is already taken, it will fail and an error will be displayed.
Screenshot 2022-11-24 at 11 16 12

Any background context you can provide?

https://github.com/giantswarm/giantswarm/issues/21478

@gusevda gusevda added kind/feature Introducing a new featur 8000 e kind/ux-enhancement Improving existing functionality labels Nov 24, 2022
@gusevda gusevda requested a review from a team November 24, 2022 08:27
@kuosandys
Copy link
Contributor
kuosandys commented Nov 29, 2022

Looks good in general from what I can tell! Thanks for including an explanation of the nuances of app bundle installation. Would we also be adding some tests for app bundle installation to this PR?

Also, I know we're just adding support for installation with this PR, but I was wondering if you knew whether we'd also need to adapt app uninstallation/deletion?

@gusevda
Copy link
Contributor Author
gusevda commented Nov 30, 2022

Also, I know we're just adding support for installation with this PR, but I was wondering if you knew whether we'd also need to adapt app uninstallation/deletion?

From what I experienced, app bundle deletion works well. But let me double check it.

@gusevda gusevda requested a review from kuosandys December 7, 2022 13:03
@gusevda gusevda merged commit 0802e16 into main Dec 7, 2022
@gusevda gusevda deleted the app-bundles-installation branch December 7, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Introducing a new feature kind/ux-enhancement Improving existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0