Allow to delete a group prefix in permissions overview #3974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently the permission inspection UI in its "Group" mode restricts the user entry to group names starting with
customer:. Recently we started to allow for additionalDexconnectors to be configured so the group name prefix could be different. In this PR the group name restriction was removed. We still pre-fill group name input withcustomer:prefix to remind people that most likely they need it, but it's possible to delete it.What is the effect of this change to users?
Now it's possible to submit permissions form with any group name.
Any background context you can provide?
Towards giantswarm/roadmap#1697.