Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
168d32c to
ca65119
Compare
mogottsch
approved these changes
Jan 13, 2023
anvddriesch
approved these changes
Jan 16, 2023
anvddriesch
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for selecting various dex connectors on login. Instead of calling dex with a specific
connector_id, we now useconnector_filterto filter the list of connectors, and present users with the appropriate selection list.In order to correctly determine whether the logged in user is an "admin" within happa, we've previously checked whether the user has membership in the group referenced by
window.config.mapiAuthAdminGroup. Since each identity provider has a different admin group name, this field is now an array of admin groups.What is the effect of this change to users?
For customers:
After clicking on "Proceed to login", users will now be presented with dex's connector selection page of all customer connectors (connectors starting with
customer).For GS staff:
After navigating to
/admin-login, users will now be presented with dex's connector selection page of all GS connectors (connectors starting withgiantswarm).Any background context you can provide?
Closes giantswarm/roadmap#1845.
What is needed from the reviewers?
Verify that logging in presents you with the dex connector selection page, and that logging in using any GS connectors provides you with admin features within happa (i.e. you can see internal app catalogs; you have the "Experiments" selection available to you in the dropdown menu located at the top right corner of the screen).