feat : excluede paths by regex #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkerou
reviewed
Jun 4, 2020
handler.go
Outdated
| @@ -73,5 +73,5 @@ func (g *gzipHandler) shouldCompress(req *http.Request) bool { | |||
| return false | |||
| } | |||
|
|
|||
| return !g.ExcludedPaths.Contains(req.URL.Path) | |||
| return !g.ExcludedPaths.Contains(req.URL.Path) && !g.ExcludedPathesRegexs.Contains(req.URL.Path) | |||
thinkerou
reviewed
Jun 4, 2020
options.go
Outdated
| @@ -5,6 +5,8 @@ import ( | |||
| "net/http" | |||
| "strings" | |||
|
|
|||
There was a problem hiding this comment.
remove the empty line and fmt it
thinkerou
reviewed
Jun 4, 2020
| @@ -36,6 +39,11 @@ func WithExcludedPaths(args []string) Option { | |||
| o.ExcludedPaths = NewExcludedPaths(args) | |||
| } | |||
| } | |||
| func WithExcludedPathsRegexs(args []string) Option { | |||
thinkerou
reviewed
Jun 4, 2020
| } | ||
| return result | ||
| } | ||
| func (e ExcludedPathesRegexs) Contains(requestURI string) bool { |
appleboy
requested changes
Jun 4, 2020
handler.go
Outdated
| @@ -72,6 +72,11 @@ func (g *gzipHandler) shouldCompress(req *http.Request) bool { | |||
| if g.ExcludedExtensions.Contains(extension) { | |||
| return false | |||
| } | |||
|
|
|||
| return !g.ExcludedPaths.Contains(req.URL.Path) | |||
| if !g.ExcludedPaths.Contains(req.URL.Path) { | |||
There was a problem hiding this comment.
add an empty line between if block.
|
@standcats build fails? |
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
===========================================
- Coverage 97.56% 84.84% -12.72%
===========================================
Files 3 3
Lines 82 99 +17
===========================================
+ Hits 80 84 +4
- Misses 1 12 +11
- Partials 1 3 +2
Continue to review full report at Codecov.
|
|
@appleboy |
|
Waiting for @thinkerou approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal
Allow regular expressions to exclude paths.
Gin can specify parameters in the URL.
In this case, the action name may be specified below the parameter.
The current exclusion doesn't allow you to specify a lower parameter, so I'd like to add it.
exp: