8000 Disable HWLOC by Default by MarcelKoch · Pull Request #1513 · ginkgo-project/ginkgo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Disable HWLOC by Default #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 13, 2024
Merged

Disable HWLOC by Default #1513

merged 2 commits into from
Feb 13, 2024

Conversation

MarcelKoch
Copy link
Member
@MarcelKoch MarcelKoch commented Dec 15, 2023 •
edited
Loading

This PR disables our HWLOC support by default. This is a softer version of #1510. It also changes the behavior of GINKGO_BUILD_HWLOC. Now, if set to ON, then it is required that HWLOC can be found.

Also, a warning is issued if GINKGO_BUILD_HWLOC=ON, since this has no (positive) effect.

Todo:

  • maybe disable HWLOC for tests

@MarcelKoch MarcelKoch self-assigned this Dec 15, 2023
@ginkgo-bot ginkgo-bot added reg:build This is related to the build system. reg:testing This is related to testing. reg:documentation This is related to documentation. mod:cuda This is related to the CUDA module. mod:hip This is related to the HIP module. labels Dec 15, 2023
@upsj upsj requested review from upsj and pratikvn February 7, 2024 09:47
pratikvn
pratikvn approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member
@pratikvn pratikvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@MarcelKoch MarcelKoch merged commit 5763056 into develop Feb 13, 2024
@MarcelKoch MarcelKoch deleted the disable-hwloc branch February 13, 2024 07:33
@upsj upsj added the 1:ST:ready-to-merge This PR is ready to merge. label Feb 13, 2024
@MarcelKoch MarcelKoch mentioned this pull request Jul 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upsj upsj upsj approved these changes

@pratikvn pratikvn pratikvn approved these changes

Assignees

@MarcelKoch MarcelKoch

Labels
1:ST:ready-to-merge This PR is ready to merge. mod:cuda This is related to the CUDA module. mod:hip This is related to the HIP module. reg:build This is related to the build system. reg:documentation This is related to documentation. reg:testing This is related to testing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MarcelKoch @upsj @pratikvn @ginkgo-bot
0