8000 Add `array::copy_to_host` function by upsj · Pull Request #1835 · ginkgo-project/ginkgo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add array::copy_to_host function #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2025
Merged

Add array::copy_to_host function #1835

merged 2 commits into from
Apr 26, 2025

Conversation

upsj
Copy link
Member
@upsj upsj commented Apr 22, 2025

For debugging and development purposes, this makes it easier to get a host view of device data.

@upsj upsj added the 1:ST:ready-for-review This PR is ready for review label Apr 22, 2025
@upsj upsj requested a review from a team April 22, 2025 12:06
@upsj upsj self-assigned this Apr 22, 2025
@ginkgo-bot ginkgo-bot added reg:testing This is related to testing. mod:core This is related to the core module. labels Apr 22, 2025
@upsj upsj force-pushed the array_copy_to_host branch from 163c319 to 2b15202 Compare April 22, 2025 12:19
Copy link
Member
@MarcelKoch MarcelKoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A bit confused that we don't have a unified array test, but that is not really relevant to the PR.

@upsj upsj added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels Apr 22, 2025
Copy link

Copy link
codecov bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.40%. Comparing base (fc67314) to head (2b15202).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1835      +/-   ##
===========================================
+ Coverage    88.73%   89.40%   +0.67%     
===========================================
  Files          831      831              
  Lines        69570    69506      -64     
===========================================
+ Hits         61731    62141     +410     
+ Misses        7839     7365     -474     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@upsj upsj deleted the array_copy_to_host branch April 26, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1:ST:ready-to-merge This PR is ready to merge. mod:core This is related to the core module. reg:testing This is related to testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0